Skip to content

Move check outside CallableOperation. #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2020
Merged

Move check outside CallableOperation. #431

merged 1 commit into from
Jun 4, 2020

Conversation

micahstairs
Copy link
Contributor

Moves the check in FirebaseUserManager.updateTenant outside CallableOperation in TenantManager.updateTenantOp, addressing an existing TODO.

hiranya911
hiranya911 approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hiranya911 hiranya911 assigned micahstairs and unassigned hiranya911 Jun 3, 2020
@micahstairs micahstairs merged commit de6b982 into idp-config Jun 4, 2020
@micahstairs micahstairs deleted the micahstairs-update-tenant-check branch June 4, 2020 17:24
micahstairs added a commit that referenced this pull request Jun 12, 2020
@micahstairs
Move check in FirebaseUserManager.updateTenant outside CallableOperat…
0fa48b2 
…ion. (#431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

@lahirumaramba lahirumaramba Awaiting requested review from lahirumaramba

Assignees

@lahirumaramba lahirumaramba

@micahstairs micahstairs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micahstairs @hiranya911 @lahirumaramba